Re: [PATCHv2] storage: expose volume meta-type in XML

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/25/2013 10:06 AM, Daniel P. Berrange wrote:
> On Mon, Nov 25, 2013 at 09:56:48AM -0700, Eric Blake wrote:
>> I got annoyed at having to use both 'virsh vol-list $pool --details'
>> AND 'virsh vol-dumpxml $vol $pool' to learn if I had populated
>> the volume correctly.  Since two-thirds of the data present in
>> virStorageVolGetInfo() already appears in virStorageVolGetXMLDesc(),
>> this just adds the remaining piece of information, as:
>>
>> <volume type='...'>
>>   ...
>> </volume>
>>
>> * docs/formatstorage.html.in: Document new <volume type=...>.
>> * docs/schemas/storagevol.rng (vol): Add it to RelaxNG.
>> * src/conf/storage_conf.h (virStorageVolTypeToString): Declare.
>> * src/conf/storage_conf.c (virStorageVolTargetDefFormat): Output
>> the metatype.
>> (virStorageVolDefParseXML): Parse it, for unit tests.
>> * tests/storagevolxml2xmlout/vol-*.xml: Update tests to match.
>>
>> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> 
> ACK

Thanks; will push shortly.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]