On 11/25/2013 03:41 AM, Daniel P. Berrange wrote: > On Fri, Nov 22, 2013 at 03:26:11PM -0700, Eric Blake wrote: >> I got annoyed at having to use both 'virsh vol-list $pool --details' >> AND 'virsh vol-dumpxml $vol $pool' to learn if I had populated >> the volume correctly. Since two-thirds of the data present in >> virStorageVolGetInfo() already appears in virStorageVolGetXMLDesc(), >> this just adds the remaining piece of information. >> >> * docs/formatstorage.html.in: Document new <target type=...>. >> * docs/schemas/storagevol.rng (target, backingStore): Add it to >> RelaxNG. >> * src/conf/storage_conf.h (virStorageVolTypeToString): Declare. >> * src/conf/storage_conf.c (virStorageVolTargetDefFormat): Output >> the metatype. >> * tests/storagevolxml2xmlout/vol-*.xml: Update tests to match. >> >> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> >> --- > I think I'd be more inclined to have a top level attribute > eg > > <volume type=block> I debated about that, but your answer swayed me. Consider it done, v2 coming up. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list