On Mon, Nov 25, 2013 at 8:26 PM, Laine Stump <laine@xxxxxxxxx> wrote: > On 11/21/2013 04:41 PM, Ryota Ozaki wrote: >> Makefile.am, vbox_V4_3.c and vbox_driver.c do regular >> modifitions to support a new version of APIs. >> >> vbox_tmpl.c basically fixes incompatibilities since 4.2. >> >> The affected incompatibilities of 4.3 are: >> * IMachine::Delete() has been renamed to IMachine::deleteConfig() >> * IMedium::CreateBaseStorage() now accepts multiple variant values >> * IDisplay::GetScreenResolution() now returns the display position >> in the guest >> * IMachine now has multiple IUSBControllers and IUSBDeviceFilters >> handles USB device filters instead of (obsolete) IUSBController >> >> This patch is tested on Mac OS X 10.8.5 and Fedora 19. >> >> Signed-off-by: Ryota Ozaki <ozaki.ryota@xxxxxxxxx> >> --- >> src/Makefile.am | 3 +- >> src/vbox/vbox_V4_3.c | 13 +++++++++ >> src/vbox/vbox_driver.c | 8 ++++++ >> src/vbox/vbox_tmpl.c | 74 ++++++++++++++++++++++++++++++++++++++++++++++++-- >> 4 files changed, 95 insertions(+), 3 deletions(-) >> create mode 100644 src/vbox/vbox_V4_3.c > > > I won't pretend to understand anything about the differences between > vbox versions. But the chnages inserted seem sane, and it passes a "make > check && make syntax-check && make rpm" with vbox support enabled, so > ACK and pushed. Thanks a lot for your reviewing and pushing! ozaki-r > > -- > libvir-list mailing list > libvir-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/libvir-list -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list