Re: [PATCH] Don't start a nested job in qemuMigrationPrepareAny

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/22/2013 04:21 PM, Jiri Denemark wrote:
> On Tue, Nov 19, 2013 at 18:21:08 +0100, Jano Tomko wrote:
>> This nested job is canceled by the first ExitMonitor call (even though
>> it was not created by the corresponding EnterMonitor call), and
>> again in qemuMigrationPrepareAny if qemuProcessStart failed.
>> This can lead to a crash if the vm object was disposed of before calling
>> qemuDomainRemoveInactive:
>> 0  ..62bc in virClassIsDerivedFrom (klass=0xdeadbeef,
>>    parent=0x7ffce4cdd270) at util/virobject.c:166
>> 1 ..6666 in virObjectIsClass at util/virobject.c:362
>> 2 ..66b4 in virObjectLock at util/virobject.c:314
>> 3 ..477e in virDomainObjListRemove at conf/domain_conf.c:2359
>> 4 ..7a64 in qemuDomainRemoveInactive at qemu/qemu_domain.c:2087
>> 5 ..956c in qemuMigrationPrepareAny at qemu/qemu_migration.c:2469
>>
>> This was added by commit e4e2822, exposed by 5a4c237 and c7ac251.
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=1018267
>> ---
>>  src/qemu/qemu_migration.c | 8 +-------
>>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> ACK, I don't know what I was thinking about when I made e4e2822.
> 

Thanks; pushed now.

Jan


Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]