Re: [PATCH 10/11] maint: fix comma style issues: remaining code

[Osier Yang <jyang@xxxxxxxxxx>]

On 20/11/13 08:30, Eric Blake wrote:
> Most of our code base uses space after comma but not before;
> fix the remaining uses before adding a syntax check.
>
> * src/network/bridge_driver.c: Consistently use commas.
> * src/node_device/node_device_hal.c: Likewise.
> * src/node_device/node_device_udev.c: Likewise.
> * src/storage/storage_backend_rbd.c: Likewise.
>
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---
>   src/network/bridge_driver.c        | 2 +-
>   src/node_device/node_device_hal.c  | 4 ++--
>   src/node_device/node_device_udev.c | 2 +-
>   src/storage/storage_backend_rbd.c  | 2 +-
>   4 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
> index 4298576..83dc931 100644
> --- a/src/network/bridge_driver.c
> +++ b/src/network/bridge_driver.c
> @@ -1700,7 +1700,7 @@ networkAddRouteToBridge(virNetworkObjPtr network,
>
>       /* this creates an all-0 address of the appropriate family */
>       ignore_value(virSocketAddrParse(&zero,
> -                                    (VIR_SOCKET_ADDR_IS_FAMILY(addr,AF_INET)
> +                                    (VIR_SOCKET_ADDR_IS_FAMILY(addr, AF_INET)
>                                        ? "0.0.0.0" : "::"),
>                                       VIR_SOCKET_ADDR_FAMILY(addr)));
>
> diff --git a/src/node_device/node_device_hal.c b/src/node_device/node_device_hal.c
> index a019a07..fafd520 100644
> --- a/src/node_device/node_device_hal.c
> +++ b/src/node_device/node_device_hal.c
> @@ -570,7 +570,7 @@ device_removed(LibHalContext *ctx ATTRIBUTE_UNUSED,
>       virNodeDeviceObjPtr dev;
>
>       nodeDeviceLock(driverState);
> -    dev = virNodeDeviceFindByName(&driverState->devs,name);
> +    dev = virNodeDeviceFindByName(&driverState->devs, name);
>       VIR_DEBUG("%s", name);
>       if (dev)
>           virNodeDeviceObjRemove(&driverState->devs, dev);
> @@ -588,7 +588,7 @@ device_cap_added(LibHalContext *ctx,
>       virNodeDeviceObjPtr dev;
>
>       nodeDeviceLock(driverState);
> -    dev = virNodeDeviceFindByName(&driverState->devs,name);
> +    dev = virNodeDeviceFindByName(&driverState->devs, name);
>       nodeDeviceUnlock(driverState);
>       VIR_DEBUG("%s %s", cap, name);
>       if (dev) {
> diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c
> index 785c2fa..5d49968 100644
> --- a/src/node_device/node_device_udev.c
> +++ b/src/node_device/node_device_udev.c
> @@ -357,7 +357,7 @@ typedef void (*udevLogFunctionPtr)(struct udev *udev,
>                                      va_list args);
>
>   static void
> -ATTRIBUTE_FMT_PRINTF(6,0)
> +ATTRIBUTE_FMT_PRINTF(6, 0)
>   udevLogFunction(struct udev *udev ATTRIBUTE_UNUSED,
>                   int priority,
>                   const char *file,
> diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c
> index b7a41c2..b8a553d 100644
> --- a/src/storage/storage_backend_rbd.c
> +++ b/src/storage/storage_backend_rbd.c
> @@ -454,7 +454,7 @@ static int virStorageBackendRBDCreateVol(virConnectPtr conn,
>       }
>
>       if (rados_ioctx_create(ptr.cluster,
> -        pool->def->source.name,&ptr.ioctx) < 0) {
> +                           pool->def->source.name, &ptr.ioctx) < 0) {
>           virReportError(VIR_ERR_INTERNAL_ERROR,
>                          _("failed to create the RBD IoCTX. Does the pool '%s' exist?"),
>                          pool->def->source.name);

ACK

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list