On 11/18/2013 03:44 PM, Doug Goldstein wrote: > --- > libvirt-override.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) ACK. > +#if LIBVIR_CHECK_VERSION(1,0,0) Style-wise, I would have written LIBVIR_CHECK_VERSION(1, 0, 0), but I'm not sure the whitespace difference matters. > LIBVIRT_BEGIN_ALLOW_THREADS; > i_retval = virNodeGetCPUMap(conn, NULL, NULL, 0); > LIBVIRT_END_ALLOW_THREADS; > +#endif /* LIBVIR_CHECK_VERSION(1,0,0) */ > > if (i_retval < 0) { > /* fallback: use nodeinfo */ Works because of the fallback code (we have to call at least one libvirt function before returning error so that the libvirt error api has something to report). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list