On 11/18/2013 08:39 AM, Ryota Ozaki wrote: > This patch shuts up the following warning of clang > on Mac OS X: Not just clang, but also gcc. > > virsh.c:2761:22: error: assigning to 'char *' from 'const char [6]' discards qualifiers > [-Werror,-Wincompatible-pointer-types-discards-qualifiers] > rl_readline_name = "virsh"; > ^ ~~~~~~~ > > The warning happens because rl_readline_name on Mac OS X is still > 'char *', while it is 'const char *' on most platforms. This is the real bug we are working around, not clang. What version of libreadline is installed on your platform? I'm okay with the patch, but not the commit message - I want to accurately report that WHY we are tweaking things is to work around a bug in older libreadline (which has nothing to do with which compiler is used, and everything to do with the buggy older header). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list