Re: [PATCHv3 2/3] Add a name to virPortAllocator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/14/2013 02:13 PM, Martin Kletzander wrote:
> On Wed, Nov 13, 2013 at 06:01:41PM +0100, Ján Tomko wrote:
>> This allows its error messages to be more specific.
>> ---
>>  src/libxl/libxl_driver.c     | 3 ++-
>>  src/qemu/qemu_driver.c       | 9 ++++++---
>>  src/util/virportallocator.c  | 9 +++++++--
>>  src/util/virportallocator.h  | 3 ++-
>>  tests/virportallocatortest.c | 4 ++--
>>  5 files changed, 19 insertions(+), 9 deletions(-)
>>
> 
> You leak the *name.  ACK if you add VIR_FREE(pa->name) into
> virPortAllocatorDispose().
> 
> Martin
> 

I have fixed the leak and pushed the series, thank you for the reviews!

Jan


Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]