On 11/15/2013 05:18 AM, Jiri Denemark wrote:
> On Fri, Nov 15, 2013 at 20:47:43 +0900, Michael Avdienko wrote:
>> QEMU 1.6.0 introduced new migration status: setup
>> Libvirt does not expect such string in QMP and refuses to migrate with error
>> "unexpected migration status in setup"
>>
>> This patch fixes it.
>>
>> Sorry for previous bad try.
>> Unfortunately I have seen Serge Hallyn's patch too late.
>> Now I think it's better to include following code into my patch:
>> if (setting_up) {
>> priv->job.info.fileTotal = -1;
>> priv->job.info.fileRemaining = -1;
>> priv->job.info.fileProcessed = 0;
>>
>
> I don't think this is needed at all, I'd just keep them all 0.
>
> This patch gets my ACK as is but I won't it push yet in case someone
> provides a good reasoning for initializing the counters to 2^64-1.
At least for block-mirror jobs, we document that if total and processed
are equal, the job is done with phase 1 and the user can finally perform
a pivot. But this is migration, not block-mirror; and I don't know if
we have any code that would be confused by a total of 0 and a remaining
of 0. In other words, I don't know of any reason that all 0 wouldn't work.
[Hmm, I just noticed that libvirt.h claims that job info timing is
tracked in 'mill-seconds', whatever those are]
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list