Re: [PATCH 6/6] qemuProcessReconnectHelper: Don't create joinable thread

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14.11.2013 12:55, Martin Kletzander wrote:
> On Thu, Nov 14, 2013 at 10:51:16AM +0100, Michal Privoznik wrote:
>> In the qemuProcessReconnectHelper() a new thread that do all the
> 
> s/do/does/
> 
>> interesting work is spawned. The rationale is to not block the daemon
>> startup process in case of unresponsive qemu. However, the thread
>> handler is a local variable which gets lost once the control goes out of
>> scope. Hence, the thread gets leaked. We can avoid this if the thread
> 
> s/,// ???
> 
>> isn't make joinable.
>>
> 
> s/make/made/
> 
>> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
>> ---
>>  src/qemu/qemu_process.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
> 
> ACK,
> 
> Martin

Thanks. I've pushed the patches except for 4/6 which we doesn't have a
clear consensus on yet.

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]