On 11/13/13 00:45, Eric Blake wrote: > While trying to compare netfs against my new gluster pool, I > discovered two things: > > virt-xml-validate chokes on valid xml produced by 'virsh pool-dumpxml' > [yet another reason that ALL patches that add new xml should be adding > corresponding tests] > > When using glusterfs FUSE mounts, you cannot access a subdirectory > of a gluster volume. The recommended workaround in the gluster > community is to mount the volume to an intermediate location, then > bind-mount the desired subdirectory to the final location. Maybe > we should teach libvirt to do bind-mounting, but for now I chose to > just document the limitation. > > * docs/storage.html.in: Improve documentation. > * docs/schemas/storagepool.rng (sourcefmtnetfs): Allow all > formats, and drop redundant info-vendor. > * tests/storagepoolxml2xmltest.c (mymain): New test. > * tests/storagepoolxml2xmlin/pool-netfs-gluster.xml: New file. > * tests/storagepoolxml2xmlout/pool-netfs-gluster.xml: Likewise. > > Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> > --- > > We added glusterfs support to netfs pools in 2009 (commit 2562303); > it's been broken for quite some time :( > > docs/schemas/storagepool.rng | 5 ++--- > docs/storage.html.in | 11 ++++++++--- > tests/storagepoolxml2xmlin/pool-netfs-gluster.xml | 12 ++++++++++++ > tests/storagepoolxml2xmlout/pool-netfs-gluster.xml | 20 ++++++++++++++++++++ > tests/storagepoolxml2xmltest.c | 1 + > 5 files changed, 43 insertions(+), 6 deletions(-) > create mode 100644 tests/storagepoolxml2xmlin/pool-netfs-gluster.xml > create mode 100644 tests/storagepoolxml2xmlout/pool-netfs-gluster.xml > ACK. Peter
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list