Re: [PATCH] python: prefer PyList_SET_ITEM to PyList_SetItem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Giuseppe Scrivano <gscrivan@xxxxxxxxxx> writes:

> Martin Kletzander <mkletzan@xxxxxxxxxx> writes:
>
>> Oh, you're right.  I was blinded by the fact, that PyList_SetItem()
>> checks whether the 'op' is a list and I was under the impression that
>> PyList_Check(op) will catch that.  This has not yet changed (I checked
>> 3.3.2), so you're right, the fact that we'll use PyList_SET_ITEM won't
>> change a thing.  I'll continue with the review in a minute.  Thanks
>> for the idea.

> If you already worked on the review, then I can split these additional
> changes and rebase them.

I'll send these changes as a separate series.

Giuseppe

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]