2013/11/1 Eric Blake <eblake@xxxxxxxxxx>: > On 11/01/2013 03:54 AM, Hongwei Bi wrote: >> 2013/11/1 Eric Blake <eblake@xxxxxxxxxx>: >>> [off-list] >>> >>> On 10/31/2013 06:20 PM, Hongwei Bi wrote: >>> >>> Your system clock is off. From your headers: > > I'm a bit surprised that you re-added the list regarding an off-list > suggestion; but thank you for fixing your system clock. > >> It seems that there is no need to add this patch. But the caller >> virNetworkDefFormatInternal() has a check of the return value which is >> described as " if (virNetworkDNSDefFormat(buf, &def->dns) < 0) ". So I >> think we should at least change one or the other. > > No. Just becuase virNetworkDNSDefFormat() currently has no failure > paths does not mean that it will not gain some in the future. It's > safer to keep the caller code checking for errors, even if none > currently happen. The existing code is fine as is. > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > Thanks for your explanation. As you say above , is it the same case the virNetworkObjReplacePersistentDef 's definition and its usage in network_conf.c ? -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list