Eric Blake wrote:
> On 10/31/2013 06:23 PM, Jim Fehlig wrote:
>
>
>>> + for (i = 0; i < virBitmapSize(cpumask); ++i) {
>>> + bool bit;
>>> + if (virBitmapGetBit(cpumask, i, &bit) < 0) {
>>> + virReportError(VIR_ERR_INTERNAL_ERROR,
>>> + _("Failed to get cpumask bit '%zd' with
>>> libxenlight"), i);
>>>
>> I don't think that is the most informative error message, but can't
>> really suggest anything better since I'm having a problem understanding
>> how virtBitmapGetBit() could fail.
>>
>
> Typically it fails only for an out-of-range request, which is a coding
> error. So some places use ignore_value() rather than bothering with an
> unreachable error message.
>
Would there be any objections to committing this, with the use of
ignore_value() squashed in?
Regards,
Jim
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list