Re: [PATCH] network_conf.c: correct the value of the 'result' variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/31/2013 06:20 PM, Hongwei Bi wrote:
> The result variable in virNetworkDNSDefFormat() function should be
> initialized to -1 at first,only in this way can we use it properly.
> 
> Signed-off-by: Hongwei Bi <hwbi2008@xxxxxxxxx>
> ---
>  src/conf/network_conf.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

NACK.  After applying your patch, 'make check' fails:

TEST: networkxml2xmltest
      !!!!!!!.....!.!!!!!!!!!!                 24  FAIL

FAIL: networkxml2xmlupdatetest
==============================

TEST: networkxml2xmlupdatetest
      ...!..!!!.!!!....!.!.!....!..!.........! 40  FAIL

Please don't submit patches that fail 'make check' or 'make
syntax-check'; it is a drain on reviewer resources.


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]