On Wed, Oct 30, 2013 at 02:17:32PM -0700, Ian Main wrote: > On Wed, Oct 30, 2013 at 10:52:19AM +0100, Christophe Fergeau wrote: > > ACK > > > > Do you have push access to libvirt git repos? > > No I do not. I've pushed this for you, though I had to squash diff --git a/libvirt-gconfig/libvirt-gconfig-domain-interface-filterref.h b/libvirt-gconfig/libvirt-gconfig-domain-interface-filterref.h index 4a2bfd4..d68dfe5 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-interface-filterref.h +++ b/libvirt-gconfig/libvirt-gconfig-domain-interface-filterref.h @@ -24,6 +24,8 @@ #error "Only <libvirt-gconfig/libvirt-gconfig.h> can be included directly." #endif +#include <libvirt-gconfig/libvirt-gconfig-domain-interface-filterref-parameter.h> + #ifndef __LIBVIRT_GCONFIG_DOMAIN_INTERFACE_FILTERREF_H__ #define __LIBVIRT_GCONFIG_DOMAIN_INTERFACE_FILTERREF_H__ or it would not build. Also, the v2: v3: annotations below should go below the '---' separator so that git am does not think they are part of the commit log. I've also pushed the fix for the python example. Thanks for the patches! Christophe > > On Tue, Oct 29, 2013 at 12:13:38PM -0700, Ian Main wrote: > > > This patch adds support for setting filterref's on interfaces. Also > > > supported are parameters to the filterref's. > > > > > > V2: > > > > > > - alphabetical orderized (don't look it up!) Makefile.am > > > - s/set_filter/set_name/ s/get_filter/get_name/ > > > - remove trailing whitespace. > > > - fix missing line. > > > - add return_val_if_fail check. > > > - moved qcow fix in demo to a new patch. > > > - fixed new_from_xml(). > > > > > > V3: > > > > > > - added g_debug in add_filterref_parameter(); > > > - more fixing new_from_xml(). > > > - orderized (I like this word now) libvirt-gconfig.h includes. > > > > > > Signed-off-by: Ian Main <imain@xxxxxxxxxx>
Attachment:
pgpkW8CCpb7wN.pgp
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list