Re: [PATCH] maint: avoid further typedef accidents

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/30/2013 02:24 AM, Ján Tomko wrote:
> On 10/29/2013 09:04 PM, Eric Blake wrote:
>> To make it easier to forbid future attempts at a confusing typedef
>> name ending in Ptr that isn't actually a pointer, insist that we
>> follow our preferred style of 'typedef foo *fooPtr'.
>>
>> * cfg.mk (sc_forbid_const_pointer_typedef): Enforce consistent
>> style, to prevent issue fixed in previous storage patch.
>> * src/conf/capabilities.h (virCapsPtr): Fix offender.
>> * src/security/security_stack.c (virSecurityStackItemPtr):
>> Likewise.
>> * tests/qemucapabilitiestest.c (testQemuDataPtr): Likewise.
>>
>> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
>> ---
>>  cfg.mk                        | 4 ++++
>>  src/conf/capabilities.h       | 4 ++--
>>  src/security/security_stack.c | 2 +-
>>  tests/qemucapabilitiestest.c  | 2 +-
>>  4 files changed, 8 insertions(+), 4 deletions(-)
>>
> 
> ACK

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]