On Thu, Oct 17, 2013 at 03:10:20PM +0200, Peter Krempa wrote: > Currently we were storing domain feature flags in a bit field as the > they were either enabled or disabled. New features such as paravirtual > spinlocks however can be tri-state as the default option may depend on > hypervisor version. > > To allow storing tri-state feature state in the same place instead of > having to declare dedicated variables for each feature this patch > refactors the bit field to an array. > --- > > Notes: > Version 2: > - clarified the intent of this patch in the commit message > > src/conf/domain_conf.c | 159 ++++++++++++++++++++++++++++++--------------- > src/conf/domain_conf.h | 2 +- > src/libxl/libxl_conf.c | 9 ++- > src/lxc/lxc_container.c | 6 +- > src/qemu/qemu_command.c | 15 ++--- > src/vbox/vbox_tmpl.c | 45 +++++++------ > src/xenapi/xenapi_driver.c | 10 +-- > src/xenapi/xenapi_utils.c | 22 +++---- > src/xenxs/xen_sxpr.c | 20 +++--- > src/xenxs/xen_xm.c | 30 ++++----- > 10 files changed, 187 insertions(+), 131 deletions(-) ACK, would prefer a second reviewer. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list