Re: [PATCH] Fix leak of objects when reconnecting to QEMU instances

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/29/2013 07:59 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
> 
> The 'error' cleanup block in qemuProcessReconnect() had a
> 'return' statement in the middle of it. This caused a leak
> of virConnectPtr & virQEMUDriverConfigPtr instances. This
> was identified because netcf recently started checking its
> refcount in libvirtd shutdown:
> 
> netcfStateCleanup:109 : internal error: Attempt to close netcf state driver with open connections
> 
> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> ---
>  src/qemu/qemu_process.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

ACK; worth having in 1.1.4.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]