On 10/28/2013 10:08 PM, Chen Hanxiao wrote: > From: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> > > If we need to exclude one parameters from another, > we could use this member to specify one. > > With this flag, we could archive what Eric comment on: > https://www.redhat.com/archives/libvir-list/2013-October/msg00965.html > 1. COMMAND <TAB> or COMMAND --<TAB> > Auto complete will NOT show option that marked as VSH_OT_ALIAS > 2. COMMAND --sh<TAB> > Auto complete will show --shareable > (this one was marked as VSH_OT_ALIAS) > 3. COMMAND --mode XXX <TAB> or COMMAND --mode XXX --sh<TAB> > Auto complete will NOT show --shareable > (we set new member exclude_option for mode) > 4. COMMAND --shareable --mo<TAB> > Auto complete will NOT show --mode > (we set new member exclude_option for mode) > > Signed-off-by: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> > --- > v2: > use camelCase for struct members > enable excludeOption to hold more than one options by > a comma seperated string. I'm not sure we need this patch. Tab completion already needs to be improved for other reasons, and adding this patch just for the sake of patch 2/2, which I already said is probably not necessary, seems like it would just be churn for Tomas' work on overall improvements. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list