On 23.10.2013 07:17, Claudio Bley wrote: > At Tue, 22 Oct 2013 16:27:02 +0100, > Michal Privoznik wrote: >> >> On 22.10.2013 09:29, Daniel P. Berrange wrote: >>> On Mon, Oct 21, 2013 at 03:36:11PM -0600, Jim Fehlig wrote: >>>> >From a0f35945f3127ab70d051101037e821b1759b4bb Mon Sep 17 00:00:00 2001 >>>> From: Jim Fehlig <jfehlig@xxxxxxxx> >>>> Date: Mon, 21 Oct 2013 15:30:02 -0600 >>>> Subject: [PATCH] build: fix virt-login-shell build with apparmor >>>> >>>> With libapparmor-devel installed, virt-login-shell fails to link >>>> >>>> CCLD virt-login-shell >>>> ../src/.libs/libvirt-setuid-rpc-client.a(libvirt_setuid_rpc_client_la-vircommand.o): In function `virExec': >>>> /home/jfehlig/virt/upstream/libvirt/src/util/vircommand.c:653: undefined reference to `aa_change_profile' >>>> collect2: error: ld returned 1 exit status >>>> >>>> Fix by linking libvirt_setuid_rpc_client with previously determined >>>> SECDRIVER_LIBS in src/Makefile.am. While at it, introduce SECDRIVER_CFLAGS >>>> and use both throughout src/Makefile.am where it makes sense. >>>> >>>> Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx> >>>> --- >>>> src/Makefile.am | 16 +++++++--------- >>>> 1 file changed, 7 insertions(+), 9 deletions(-) >> >>> >>> ACK to this version of the patch >>> >>> Daniel >>> >> >> I went ahead and pushed this as it's build breaker which I'm >> experiencing everytime I try to build (yes, I do build with >> AppArmor). > > [too bad you didn't clean up the commit message beforehand...] Oh my, I didn't? Sorry, I've just took the patch, applied it and checked it fixes the issue I'm seeing. > > Could someone cherrypick this to the maint branches as well, please?! > > And, while at it, maybe also e350826c6 and 843bdb2f8a3. I've backported all three patches onto v1.1.3-maint and v1.1.2-maint branches. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list