On 10/22/2013 01:21 PM, Michal Privoznik wrote: > As stated in the comment above introduction of the lv_abs_top_builddir > variable, older automake doesn't provide abs_top_builddir variable. > Hence, we are creating our own one with lv_ prefix. However, when > exporting env variables to the tests, the variables are not evaluated > but only substituted. Hence: > > LIBVIRT_DRIVER_DIR="$(abs_top_builddir)/src/.libs" > > is set to "/src/.libs" with old automake (even though we *think* we've > set the $abs_top_builddir variable just a few line above). > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > tests/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ACK. > > diff --git a/tests/Makefile.am b/tests/Makefile.am > index a47d376..866ecd4 100644 > --- a/tests/Makefile.am > +++ b/tests/Makefile.am > @@ -345,7 +345,7 @@ TESTS_ENVIRONMENT = \ > CONFIG_HEADER="`cd '$(top_builddir)'; pwd`/config.h" \ > PATH="$(path_add)$(PATH_SEPARATOR)$$PATH" \ > SHELL="$(SHELL)" \ > - LIBVIRT_DRIVER_DIR="$(abs_top_builddir)/src/.libs" \ > + LIBVIRT_DRIVER_DIR="$(lv_abs_top_builddir)/src/.libs" \ > LIBVIRT_AUTOSTART=0 \ > LC_ALL=C \ > VIR_TEST_EXPENSIVE=$(VIR_TEST_EXPENSIVE) \ > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list