Re: [PATCH] build: fix build of virt-login-shell on systems with older gnutls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/22/2013 06:29 AM, Jim Fehlig wrote:
> On systems where gnutls uses libgcrypt, I'm seeing the following
> build failure
> 
> libvirt.c:314: error: variable 'virTLSThreadImpl' has initializer but incomplete type
> libvirt.c:319: error: 'GCRY_THREAD_OPTION_PTHREAD' undeclared here (not in a function)
> ...
> 
> Fix by undefining WITH_GNUTLS_GCRYPT in config-post.h
> 
> Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx>
> ---
> 
> Although I'm more confident in this fix vs the previously reported
> virt-login-shell build failure, I'd still prefer an ACK before pushing.

I'm not sure on the other one yet, but can definitely ACK this one.

(Oh, and it's a pity that gnutls is now effectively LGPLv3+ if it uses
libnettle which in turn uses LGPLv3+ libgmp - because that makes libvirt
unusable with GPLv2-only programs like Oz on platforms with newer
gnutls. At least your situation with older gnutls is not impacted,
because things are still LGPLv2+)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]