Re: [PATCH]lxc: improve readability of lxcContainer[Send|Waitfor]Continue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 16.10.2013 08:27, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx>
> 
> Currently, lxcContainer[Send|Waitfor]Continue only tell
> us 'fd', but we had to deal with the interaction between
> lxc_[container|controller|process].
> This patch adds parameters to identify the caller.
> 
> Signed-off-by: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx>
> ---
>  src/lxc/lxc_container.c  | 16 +++++++++-------
>  src/lxc/lxc_container.h  |  4 ++--
>  src/lxc/lxc_controller.c |  6 +++---
>  src/lxc/lxc_process.c    |  2 +-
>  4 files changed, 15 insertions(+), 13 deletions(-)

I think this can be achieved even without this hack. We already can
produce a stack trace on VIR_DEBUG() [1]. And if you don't want to keep
only some debug messages, apply filters.

Michal

1: http://libvirt.org/logging.html#log_syntax

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]