On 18.10.2013 07:42, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx>
>
> Mark '--shareable' as VSH_OFLAG_IGNORE and
> delete related description in docs.
>
> Signed-off-by: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx>
> ---
> tools/virsh-domain.c | 1 +
> tools/virsh.pod | 3 +--
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
> index 2aed9f9..b5b9006 100644
> --- a/tools/virsh-domain.c
> +++ b/tools/virsh-domain.c
> @@ -313,6 +313,7 @@ static const vshCmdOptDef opts_attach_disk[] = {
> },
> {.name = "shareable",
> .type = VSH_OT_BOOL,
> + .flags = VSH_OFLAG_IGNORE,
> .help = N_("shareable between domains")
> },
> {.name = "rawio",
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index 7af5503..cb273e0 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -1923,7 +1923,7 @@ expected.
> [[[I<--live>] [I<--config>] | [I<--current>]] | [I<--persistent>]]
> [I<--driver driver>] [I<--subdriver subdriver>] [I<--cache cache>]
> [I<--type type>] [I<--mode mode>] [I<--config>] [I<--sourcetype soucetype>]
> -[I<--serial serial>] [I<--wwn wwn>] [I<--shareable>] [I<--rawio>]
> +[I<--serial serial>] [I<--wwn wwn>] [I<--rawio>]
> [I<--address address>] [I<--multifunction>] [I<--print-xml>]
>
> Attach a new disk device to the domain.
> @@ -1945,7 +1945,6 @@ I<sourcetype> can indicate the type of source (block|file)
> I<cache> can be one of "default", "none", "writethrough", "writeback",
> "directsync" or "unsafe".
> I<serial> is the serial of disk device. I<wwn> is the wwn of disk device.
> -I<shareable> indicates the disk device is shareable between domains.
> I<rawio> indicates the disk needs rawio capability.
> I<address> is the address of disk device in the form of pci:domain.bus.slot.function,
> scsi:controller.bus.unit or ide:controller.bus.unit.
>
Wow, we've never wanted to hide any option before? I've recall
introducing VSH_OT_ALIAS, but there hasn't been anything else?
Michal
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list