Re: [PATCHv2 04/23] cpu: Add support for loading and storing CPU data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 15, 2013 at 02:30:33PM +0200, Peter Krempa wrote:
> From: Jiri Denemark <jdenemar@xxxxxxxxxx>
> 
> This patch adds cpuDataFormat and cpuDataParse APIs to be used in unit
> tests for testing APIs that deal with virCPUData. In the x86 world, this
> means we can now store/load arbitrary CPUID data in the test suite to
> check correctness of CPU related APIs that could not be tested before.
> 
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
>  src/cpu/cpu.c            |  41 ++++++++++++++
>  src/cpu/cpu.h            |  14 +++++
>  src/cpu/cpu_x86.c        | 135 +++++++++++++++++++++++++++++++++++++++--------
>  src/libvirt_private.syms |   2 +
>  4 files changed, 171 insertions(+), 21 deletions(-)

ACK

> diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c
> index 9eb7df5..548edc7 100644
> --- a/src/cpu/cpu.c
> +++ b/src/cpu/cpu.c
> @@ -442,6 +442,47 @@ cpuHasFeature(const virCPUData *data,
>      return driver->hasFeature(data, feature);
>  }
> 
> +char *
> +cpuDataFormat(const virCPUData *data)

Site-note: one day we should change all these methods to have a 'virCPU'
prefix.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]