Re: [PATCHv2 01/23] schema: Rename option to make it reusable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 15, 2013 at 02:30:30PM +0200, Peter Krempa wrote:

Be nice to mention what you are renaming in the commit message
rather than just "option".

> ---
>  docs/schemas/domaincommon.rng | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index 10b017f..14b6700 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -4119,17 +4119,17 @@
>        <interleave>
>          <optional>
>            <element name="relaxed">
> -            <ref name="hypervtristate"/>
> +            <ref name="featurestate"/>
>            </element>
>          </optional>
>          <optional>
>            <element name="vapic">
> -            <ref name="hypervtristate"/>
> +            <ref name="featurestate"/>
>            </element>
>          </optional>
>          <optional>
>            <element name="spinlocks">
> -            <ref name="hypervtristate"/>
> +            <ref name="featurestate"/>
>              <optional>
>                <attribute name="retries">
>                  <data type="unsignedInt"/>
> @@ -4141,7 +4141,7 @@
>      </element>
>    </define>
> 
> -  <define name="hypervtristate">
> +  <define name="featurestate">
>      <attribute name="state">
>        <choice>
>          <value>on</value>

ACK if you expand the commit message.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]