On Tue, Oct 15, 2013 at 11:54:27AM +0800, Chen Hanxiao wrote: > From: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> > > Current disk could accept both 'readonly' and 'shareable' > at the same time. > But '--mode' could only accept one parameter. > > This patch enables '--mode' accept parameters like examples below: > > virsh # attach-disk domain /home/1.img sdd --mode shareable,readonly That does not make sense - these options are mutually exclusive. Anything 'readonly' is implicitly 'shareable' without 'shareable' being required. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list