On Tue, Oct 08, 2013 at 11:29:04AM -0600, Eric Blake wrote: > 'const fooPtr' is the same as 'foo * const' (the pointer won't > change, but it's contents can). But in general, if an interface > is trying to be const-correct, it should be using 'const foo *' > (the pointer is to data that can't be changed). > > Fix up offenders in src/qemu. > > * src/qemu/qemu_bridge_filter.h (networkAllowMacOnPort) > (networkDisallowMacOnPort): Use intended type. > * src/qemu/qemu_bridge_filter.c (networkAllowMacOnPort) > (networkDisallowMacOnPort): Likewise. > * src/qemu/qemu_command.c (qemuBuildTPMBackendStr) > (qemuBuildTPMDevStr, qemuBuildCpuArgStr) > (qemuBuildObsoleteAccelArg, qemuBuildMachineArgStr) > (qemuBuildSmpArgStr, qemuBuildNumaArgStr): Likewise. > * src/qemu/qemu_conf.c (qemuSharedDeviceEntryCopy): Likewise. > * src/qemu/qemu_driver.c (qemuDomainSaveImageStartVM): Likewise. > * src/qemu/qemu_hostdev.c > (qemuDomainHostdevNetConfigVirtPortProfile): Likewise. > * src/qemu/qemu_monitor_json.c > (qemuMonitorJSONAttachCharDevCommand): Likewise. > > Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> > --- > src/qemu/qemu_bridge_filter.c | 10 +++++----- > src/qemu/qemu_bridge_filter.h | 10 +++++----- > src/qemu/qemu_command.c | 20 ++++++++++---------- > src/qemu/qemu_conf.c | 2 +- > src/qemu/qemu_driver.c | 2 +- > src/qemu/qemu_hostdev.c | 2 +- > src/qemu/qemu_monitor_json.c | 2 +- > 7 files changed, 24 insertions(+), 24 deletions(-) ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list