On 10/10/2013 02:49 PM, Geoff Hickey wrote: > Eric: No problem, I'll resubmit with git (sorry about that, it's been long > enough since my last submit that I forgot about that), but I'll fix the > issue that Doug pointed out first. As for the pointer comparison to NULL, > I'm in complete agreement, but that particular source file uses the != NULL > idiom everywhere. I'd be happy to remove it everywhere, but that should be > done as a separate submit, I would think? Indeed, if you're going to clean up the entire file, do it as a separate commit. > > Thanks, 2nd try soon. :) Looking forward to it. Also, we tend to avoid top-posting on this list. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list