On 10/10/2013 03:23 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=994364 > > Whenever we check for ABI stability, we have new xml (e.g. provided by > user, or obtained from snapshot, whatever) which we compare to old xml > and see if ABI won't break. However, if the new xml was produced via > virDomainGetXMLDesc(..., VIR_DOMAIN_XML_MIGRATABLE) it lacks some > devices, e.g. 'pci-root' controller. Hence, the ABI stability check > fails even though it is stable. Moreover, we can't simply fix > virDomainDefCheckABIStability because removing the correct devices is > task for the driver. For instance, qemu driver wants to remove the usb > controller too, while LXC driver doesn't. That's why we need special > qemu wrapper over virDomainDefCheckABIStability which removes the > correct devices from domain XML, produces MIGRATABLE xml and calls the > check ABI stability function. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > src/qemu/qemu_domain.c | 22 ++++++++++++++++++++++ > src/qemu/qemu_domain.h | 3 +++ > src/qemu/qemu_driver.c | 10 ++-------- > src/qemu/qemu_migration.c | 4 ++-- > 4 files changed, 29 insertions(+), 10 deletions(-) Yes, this will make life simpler for all callers. ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list