Hi, On 10 October 2013 17:20, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote: > On Thu, Oct 10, 2013 at 05:10:41PM +0530, Pranavkumar Sawargaonkar wrote: >> AArch64 qemu has similar behavior as armv7l, like use of mmio etc. >> This patch adds similar bypass checks what we have for armv7l to aarch64. >> E.g. we are enabling mmio transport for Nicdev. >> Making addDefaultUSB and addDefaultMemballoon to false etc. >> >> Signed-off-by: Anup Patel <anup.patel@xxxxxxxxxx> >> Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@xxxxxxxxxx> >> --- >> src/qemu/qemu_capabilities.c | 2 +- >> src/qemu/qemu_command.c | 8 +++++--- >> src/qemu/qemu_domain.c | 5 ++++- >> 3 files changed, 10 insertions(+), 5 deletions(-) > > Our general rule is that changes to qemu_command.c should be accompanied > by additions to tests/qemuxml2argvtest.c to validate their correctness, > otherwise it is all to easy for us to have regressions in behaviour later. Ok i will revise this patch. > > Daniel > -- > |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| > |: http://libvirt.org -o- http://virt-manager.org :| > |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| > |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| Thanks, Pranav -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list