On 10/08/2013 06:46 PM, Peter Krempa wrote:
> Prefer using VFIO (if available) to the legacy KVM device passthrough.
>
> With this patch a PCI passthrough device without the driver configured
> will be started with VFIO if it's available on the host. If not legacy
> KVM passthrough is checked and error is reported if it's not available.
> ---
>
> Notes:
> Version 4:
> - Adapted to call tree change
>
> docs/formatdomain.html.in | 9 ++++-----
> src/conf/domain_conf.h | 2 +-
> src/qemu/qemu_command.c | 2 +-
> src/qemu/qemu_hostdev.c | 30 +++++++++++++++++++++++++-----
> src/qemu/qemu_hostdev.h | 4 +++-
> src/qemu/qemu_hotplug.c | 2 +-
> src/qemu/qemu_process.c | 15 ++++++++-------
> tests/qemuxml2argvtest.c | 11 +++++++++++
> 8 files changed, 54 insertions(+), 21 deletions(-)
>
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 3689399..6f3f7cf 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -2755,11 +2755,10 @@
> backend, which is compatible with UEFI SecureBoot) or "kvm"
> (for the legacy device assignment handled directly by the KVM
> kernel module)<span class="since">Since 1.0.5 (QEMU and KVM
> - only, requires kernel 3.6 or newer)</span>. Currently, "kvm"
> - is the default used by libvirt when not explicitly provided,
> - but since the two are functionally equivalent, this default
> - could be changed in the future with no impact to domains that
> - don't specify anything.
> + only, requires kernel 3.6 or newer)</span>. The default, when
> + the driver name is not explicitly specified, is to check wether
> + VFIO is available and use it if it's the case. If VFIO is not
> + available, the legacy "kvm" assignment is attempted.
> </dd>
> <dt><code>readonly</code></dt>
> <dd>Indicates that the device is readonly, only supported by SCSI host
> diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
> index f20a916..6b825d8 100644
> --- a/src/conf/domain_conf.h
> +++ b/src/conf/domain_conf.h
> @@ -399,7 +399,7 @@ enum virDomainHostdevSubsysType {
>
> /* the backend driver used for PCI hostdev devices */
> typedef enum {
> - VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT, /* currently kvm, could change */
> + VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT, /* detect automaticaly, prefer VFIO */
> VIR_DOMAIN_HOSTDEV_PCI_BACKEND_KVM, /* force legacy kvm style */
> VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO, /* force vfio */
>
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index 52dc295..da53c51 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -5487,7 +5487,6 @@ qemuBuildPCIHostdevDevStr(virDomainDefPtr def,
>
> switch ((virDomainHostdevSubsysPciBackendType)
> dev->source.subsys.u.pci.backend) {
> - case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT:
> case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_KVM:
> virBufferAddLit(&buf, "pci-assign");
> if (configfd && *configfd)
> @@ -5498,6 +5497,7 @@ qemuBuildPCIHostdevDevStr(virDomainDefPtr def,
> virBufferAddLit(&buf, "vfio-pci");
> break;
>
> + case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT:
> case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_TYPE_LAST:
> virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> _("PCI passhthrough type needs to be specified"));
I think this error message would be misleading to a user. What they
would think is "Oh, I need to specify the 'PCI passthrough type'; I
wonder what *that* is..." (since that's not what it's called in the
XML). But what it really means is "There is an error in the code -
u.pci.backend should have been set to either KVM or VFIO by the
functions that called here; please report this as a bug!".
As the error is right now, I think it would do as much damage as good -
maybe you could change it to "Unable to determine whether to use VFIO or
legacy KVM driver for PCI device assignment". (or something else that
avoids saying "needs to be specified").
> diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c
> index 7f3170d..81e0e88 100644
> --- a/src/qemu/qemu_hostdev.c
> +++ b/src/qemu/qemu_hostdev.c
> @@ -564,7 +564,8 @@ qemuHostdevHostSupportsPassthroughLegacy(void)
>
> static bool
> qemuPrepareHostdevPCICheckSupport(virDomainHostdevDefPtr *hostdevs,
> - size_t nhostdevs)
> + size_t nhostdevs,
> + virQEMUCapsPtr qemuCaps)
> {
> bool supportsPassthroughKVM = qemuHostdevHostSupportsPassthroughLegacy();
> bool supportsPassthroughVFIO = qemuHostdevHostSupportsPassthroughVFIO();
> @@ -581,6 +582,23 @@ qemuPrepareHostdevPCICheckSupport(virDomainHostdevDefPtr *hostdevs,
> continue;
>
> switch ((virDomainHostdevSubsysPciBackendType) *backend) {
> + case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT:
> + if (supportsPassthroughVFIO &&
> + virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VFIO_PCI)) {
> + *backend = VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO;
> + } else if (supportsPassthroughKVM &&
> + (virQEMUCapsGet(qemuCaps, QEMU_CAPS_PCIDEVICE) ||
> + virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE))) {
> + *backend = VIR_DOMAIN_HOSTDEV_PCI_BACKEND_KVM;
BTW, thinking about your response to me pointing out that this is
changing the output of a --live dumpxml, I think you're right - it's
probably a *good* thing that what was chosen is output in dumpxml.
> + } else {
> + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> + _("host doesn't support passthrough of "
> + "host PCI devices"));
> + return false;
> + }
> +
> + break;
> +
> case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO:
> if (!supportsPassthroughVFIO) {
> virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> @@ -589,7 +607,6 @@ qemuPrepareHostdevPCICheckSupport(virDomainHostdevDefPtr *hostdevs,
> }
> break;
>
> - case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT:
> case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_KVM:
> if (!supportsPassthroughKVM) {
> virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> @@ -613,7 +630,8 @@ qemuPrepareHostdevPCIDevices(virQEMUDriverPtr driver,
> const char *name,
> const unsigned char *uuid,
> virDomainHostdevDefPtr *hostdevs,
> - int nhostdevs)
> + int nhostdevs,
> + virQEMUCapsPtr qemuCaps)
> {
> virPCIDeviceListPtr pcidevs;
> int last_processed_hostdev_vf = -1;
> @@ -621,7 +639,7 @@ qemuPrepareHostdevPCIDevices(virQEMUDriverPtr driver,
> int ret = -1;
> virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
>
> - if (!qemuPrepareHostdevPCICheckSupport(hostdevs, nhostdevs))
> + if (!qemuPrepareHostdevPCICheckSupport(hostdevs, nhostdevs, qemuCaps))
> goto cleanup;
>
> virObjectLock(driver->activePciHostdevs);
> @@ -1142,13 +1160,15 @@ cleanup:
> int
> qemuPrepareHostDevices(virQEMUDriverPtr driver,
> virDomainDefPtr def,
> + virQEMUCapsPtr qemuCaps,
> bool coldBoot)
> {
> if (!def->nhostdevs)
> return 0;
>
> if (qemuPrepareHostdevPCIDevices(driver, def->name, def->uuid,
> - def->hostdevs, def->nhostdevs) < 0)
> + def->hostdevs, def->nhostdevs,
> + qemuCaps) < 0)
> return -1;
>
> if (qemuPrepareHostUSBDevices(driver, def, coldBoot) < 0)
> diff --git a/src/qemu/qemu_hostdev.h b/src/qemu/qemu_hostdev.h
> index 327d4d5..272086e 100644
> --- a/src/qemu/qemu_hostdev.h
> +++ b/src/qemu/qemu_hostdev.h
> @@ -37,7 +37,8 @@ int qemuPrepareHostdevPCIDevices(virQEMUDriverPtr driver,
> const char *name,
> const unsigned char *uuid,
> virDomainHostdevDefPtr *hostdevs,
> - int nhostdevs);
> + int nhostdevs,
> + virQEMUCapsPtr qemuCaps);
> int qemuFindHostdevUSBDevice(virDomainHostdevDefPtr hostdev,
> bool mandatory,
> virUSBDevicePtr *usb);
> @@ -50,6 +51,7 @@ int qemuPrepareHostdevSCSIDevices(virQEMUDriverPtr driver,
> int nhostdevs);
> int qemuPrepareHostDevices(virQEMUDriverPtr driver,
> virDomainDefPtr def,
> + virQEMUCapsPtr qemuCaps,
> bool coldBoot);
> void qemuDomainReAttachHostScsiDevices(virQEMUDriverPtr driver,
> const char *name,
> diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
> index 71c7822..b6ae218 100644
> --- a/src/qemu/qemu_hotplug.c
> +++ b/src/qemu/qemu_hotplug.c
> @@ -1140,7 +1140,7 @@ int qemuDomainAttachHostPciDevice(virQEMUDriverPtr driver,
> return -1;
>
> if (qemuPrepareHostdevPCIDevices(driver, vm->def->name, vm->def->uuid,
> - &hostdev, 1) < 0)
> + &hostdev, 1, priv->qemuCaps) < 0)
> return -1;
>
> switch ((virDomainHostdevSubsysPciBackendType) backend) {
> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
> index 079f062..354e079 100644
> --- a/src/qemu/qemu_process.c
> +++ b/src/qemu/qemu_process.c
> @@ -3567,6 +3567,12 @@ int qemuProcessStart(virConnectPtr conn,
> goto cleanup;
> }
>
> + VIR_DEBUG("Determining emulator version");
> + virObjectUnref(priv->qemuCaps);
> + if (!(priv->qemuCaps = virQEMUCapsCacheLookupCopy(driver->qemuCapsCache,
> + vm->def->emulator)))
> + goto cleanup;
> +
> /* network devices must be "prepared" before hostdevs, because
> * setting up a network device might create a new hostdev that
> * will need to be setup.
> @@ -3577,7 +3583,8 @@ int qemuProcessStart(virConnectPtr conn,
>
> /* Must be run before security labelling */
> VIR_DEBUG("Preparing host devices");
> - if (qemuPrepareHostDevices(driver, vm->def, !migrateFrom) < 0)
> + if (qemuPrepareHostDevices(driver, vm->def, priv->qemuCaps,
> + !migrateFrom) < 0)
> goto cleanup;
>
> VIR_DEBUG("Preparing chr devices");
> @@ -3659,12 +3666,6 @@ int qemuProcessStart(virConnectPtr conn,
> }
> }
>
> - VIR_DEBUG("Determining emulator version");
> - virObjectUnref(priv->qemuCaps);
> - if (!(priv->qemuCaps = virQEMUCapsCacheLookupCopy(driver->qemuCapsCache,
> - vm->def->emulator)))
> - goto cleanup;
> -
> if (!qemuValidateCpuMax(vm->def, priv->qemuCaps))
> goto cleanup;
>
> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
> index 58165fd..92e7461 100644
> --- a/tests/qemuxml2argvtest.c
> +++ b/tests/qemuxml2argvtest.c
> @@ -98,6 +98,7 @@ static int testCompareXMLToArgvFiles(const char *xml,
> virConnectPtr conn;
> char *log = NULL;
> virCommandPtr cmd = NULL;
> + size_t i;
>
> if (!(conn = virGetConnect()))
> goto out;
> @@ -154,6 +155,16 @@ static int testCompareXMLToArgvFiles(const char *xml,
> if (qemuAssignDeviceAliases(vmdef, extraFlags) < 0)
> goto out;
>
> + for (i = 0; i < vmdef->nhostdevs; i++) {
> + virDomainHostdevDefPtr hostdev = vmdef->hostdevs[i];
> +
> + if (hostdev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS &&
> + hostdev->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI &&
> + hostdev->source.subsys.u.pci.backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT) {
> + hostdev->source.subsys.u.pci.backend = VIR_DOMAIN_HOSTDEV_PCI_BACKEND_KVM;
> + }
> + }
> +
> if (!(cmd = qemuBuildCommandLine(conn, &driver, vmdef, &monitor_chr,
> (flags & FLAG_JSON), extraFlags,
> migrateFrom, migrateFd, NULL,
ACk, with a less misleading error message.
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list