Re: [PATCHv3 1/3] qemu: hostdev: Refactor PCI passhrough handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/07/13 16:59, Eric Blake wrote:
> On 10/07/2013 08:16 AM, Peter Krempa wrote:
> 
...
>>> Again - I dislike having these sentinel values showing up in switch
>>> statements (searching the source I see it a lot), as it could lead
>>> someone to believe that those are actually valid values. I may be
>>> outvoted on this though :-)
>>
>> I think that the benefits of the compiler warning in case you add a new
>> variable on places you might have forgotten outweigh a few occurences of
>> unused type in the code.
> 
> Agreed.  Maybe we should patch HACKING to capture the outcome of this
> discussion.
> 

I pushed this one with two trivial fixes according to ACK from Laine.

Fixes done were: Removed double space in one of the conditions and
changed the second addition of backend variable to non-pointer.

Peter


Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]