On 09/27/2013 08:55 PM, Eric Blake wrote: > I tried to test ./configure --without-lxc --without-remote. > First, the build failed with some odd errors, such as an > inability to build xen, or link failures for virNetTLSInit. > But when you think about it, once there is no remote code, > all of libvirtd is useless, any stateful driver that depends > on libvirtd is also not worth compiling, and any libraries > used only by RPC code are not needed. So I patched > configure.ac to make for some saner defaults when an > explicit disable is attempted. Similarly, since we have > migrated virnetdevbridge into generic code, the workaround > for Linux kernel stupidity must not depend on stateful > drivers being in use. > > Then there's 'make check' that needs segragation. > > Wow - quite a bit of cleanup to make --without-remote useful :) > > * configure.ac: Let --without-remote toggle defaults on stateful > drivers and other libraries. Pick up Linux kernel workarounds > even when qemu and lxc are not being compiled. > * tests/Makefile.am (test_programs): Factor out programs that > require remote. > * src/libvirt_private.syms (rpc/virnet*.h): Move... > * src/libvirt_remote.syms: ...into new file. > * src/Makefile.am (SYM_FILES): Ship new syms file. > > Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> > --- > > Looks big, but most of it is motion of text from splitting a file. > It fixes a build failure, but --enable-remote is not a regression > for this particular release (it's been broken for a while), so I'll > wait for a review even if it misses 1.1.3. Ping. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list