Re: [PATCH 1/3] Remove virConnectPtr arg from virNWFilterDefParse*

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/03/2013 09:06 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
>
> None of the virNWFilterDefParse* methods require a virConnectPtr
> arg, so just drop it
>
> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> ---
>  src/conf/nwfilter_conf.c       | 15 ++++++---------
>  src/conf/nwfilter_conf.h       |  6 ++----
>  src/nwfilter/nwfilter_driver.c |  2 +-
>  src/qemu/qemu_driver.c         |  3 +++
>  tests/nwfilterxml2xmltest.c    |  2 +-
>  5 files changed, 13 insertions(+), 15 deletions(-)
>
[...]
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index e8bc04d..7376ddb 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -612,6 +612,9 @@ qemuStateInitialize(bool privileged,
>      if (virAsprintf(&driverConf, "%s/qemu.conf", cfg->configBaseDir) < 0)
>          goto error;
>  
> +    fprintf(stderr, "Start Sleeping to cause a race\n");
> +    sleep(10);
> +    fprintf(stderr, "Done Sleeping to cause a race\n");

You probably don't want to push this :-)

ACK with that hunk removed.

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]