On 09/30/2013 01:29 PM, Eric Blake wrote: > On 09/30/2013 03:06 AM, Chen Hanxiao wrote: >> From: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> >> >> We forgot to do cleanup when lxcContainerMountFSTmpfs >> failed to bind fs as read-only. >> >> v2: fix an indentation issue Oh, and a side note. Patch changelogs, such as this paragraph... >> >> Signed-off-by: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> >> --- ...belong here, after the ---, so that 'git am' won't make them part of the permanent git history. They're highly useful to reviewers, but not so much when revisiting the code a year from now when we don't care how many iterations it took to get to a final patch. > > ACK and pushed. so I amended before actually pushing. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list