On 09/27/2013 09:48 AM, Daniel P. Berrange wrote: >> >> * cfg.mk: Let 'make install' and 'make dist' error much earlier if >> we detect a build from git without doc toolchain. >> >> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> >> --- > Can't we just make our existing rules fatal. I really don't see the point > in treating docs errors as non-fatal. If the docs are not built, or are > outdated, we should try to build them and fail if the tools aren't present. > We already require libxml.so be present, so requiring the libxml/libxslt > cli tools really isn't a burden in the great scheme of things. > > IOW, we should remove all the > > @if test -x $(XMLLINT) && test -x $(XMLCATALOG) ; then \ > @if [ -x $(XSLTPROC) ] ; then \ > > conditionals, and just let 'make' do its normal deps calculation and > errore reporting. > > As long as the docs are included in the tar.gz people building fro mthe > tar.gz will still not build the docs. Which means ./autogen.sh (via bootstrap.conf) should start requiring the doc toolchain for a git build. Makes sense, if the created tarball indeed has timestamps new enough to prevent a rebuild of the docs (easy enough to verify). I'll play with that idea, but it means that the v2 of this patch will probably miss 1.1.3. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list