On 09/27/2013 07:47 AM, Jiri Denemark wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1011330 (case D) > > qemuProcessStart created two references to virQEMUDriverConfigPtr before > calling fork(): > > cfg = virQEMUDriverGetConfig(driver); > ... > hookData.cfg = virObjectRef(cfg); > > However, the child only unreferenced hookData.cfg and the parent only > removed the cfg reference. That said, we don't need to increment the > reference counter when assigning cfg to hookData. Both the child and the > parent will correctly remove the reference on cfg (the child will do > that through hookData). > > Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx> > --- > src/qemu/qemu_process.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list