Yes, 'goto cleanup' would be better.
2013/9/25 Hongwei Bi <hwbi2008@xxxxxxxxx>
Yes, 'goto cleanup' would be better.2013/9/25 Ján Tomko <jtomko@xxxxxxxxxx>
On 09/25/2013 07:49 AM, Hongwei Bi wrote:
>
>
> ---
> tools/virsh-domain.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
> index 856e888..f6d4edd 100644
> --- a/tools/virsh-domain.c
> +++ b/tools/virsh-domain.c
> @@ -4487,8 +4487,10 @@ cmdDump(vshControl *ctl, const vshCmd *cmd)
> if (!(dom = vshCommandOptDomain(ctl, cmd, &name)))
> return false;
>
> - if (vshCommandOptStringReq(ctl, cmd, "file", &to) < 0)
> + if (vshCommandOptStringReq(ctl, cmd, "file", &to) < 0) {
> + virDomainFree(dom);
> return false;
> + }
'goto cleanup' would do the same and it's easier to read.
Alternatively, if we moved vshCommandOptStringReq before vshCommandOptDomain,
'return false' would be enough.
Jan
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list