On 09/24/2013 03:57 AM, Claudio Bley wrote: > N.B. This had no ill effects as long as O_RDONLY is defined to > to be 0, such that the expression (O_RDONLY < 0) yielded 0 > again. > > Signed-off-by: Claudio Bley <cbley@xxxxxxxxxx> > --- > src/test/test_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/test/test_driver.c b/src/test/test_driver.c > index 47c9d38..e1197c9 100644 > --- a/src/test/test_driver.c > +++ b/src/test/test_driver.c > @@ -5862,7 +5862,7 @@ testDomainScreenshot(virDomainPtr dom ATTRIBUTE_UNUSED, > if (VIR_STRDUP(ret, "image/png") < 0) > return NULL; > > - if (virFDStreamOpenFile(st, PKGDATADIR "/libvirtLogo.png", 0, 0, O_RDONLY < 0)) > + if (virFDStreamOpenFile(st, PKGDATADIR "/libvirtLogo.png", 0, 0, O_RDONLY) < 0) ACK. Embarrassing that even Coverity doesn't flag this blatant bug. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list