Re: [PATCH] Add --disable-securityfs configure option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Daniel P. Berrange [mailto:berrange@xxxxxxxxxx]
> Sent: Tuesday, September 24, 2013 1:15 PM
> To: Purcareata Bogdan-B43198
> Cc: libvir-list@xxxxxxxxxx
> Subject: Re:  [PATCH] Add --disable-securityfs configure option
> 
> On Tue, Sep 24, 2013 at 12:53:12PM +0300, Bogdan Purcareata wrote:
> > Securityfs is not enabled on all kernels running libvirt containers.
> > This patch introduces a configure option that can specify whether
> > containers should mount securityfs in their rootfs.
> 
> It would be nicer to detect this at runtime, rather than fixing it
> at build time. eg check whether the filesystem is mounted on the
> host, and if not, then don't mount it in the container.

Isn't it better to detect it based on kernel filesystem support? I mean, instead of checking whether securityfs is mounted, check whether it's present in /proc/filesystems.

> 
> Daniel
> --
> |: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
> |: http://libvirt.org              -o-             http://virt-manager.org :|
> |: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
> |: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]