On Mon, Sep 23, 2013 at 9:13 PM, Eric Blake <eblake@xxxxxxxxxx> wrote: > On 09/23/2013 09:07 AM, Nehal J Wani wrote: >> On Thu, Sep 19, 2013 at 4:02 AM, Eric Blake <eblake@xxxxxxxxxx> wrote: >>> >>> Nehal J. Wani reported on IRC a rather interesting build failure: >>> >>> In file included from util/virnetdevbridge.c:53:0: >>> /usr/include/linux/in6.h:30:8: error: redefinition of 'struct in6_addr' >>> struct in6_addr { >>> ^ >>> > >>> * Makefile.am (SUBDIRS): Put '.' first, not last. >>> >>> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> >>> --- >>> >>> Tough to argue the build-breaker rule on this one, since a >>> fresh checkout doesn't hit it (only a 'make check' without >>> a 'make', across an incremental build that happened to need >>> new configure substitutions). So I'll wait for a review >>> for my one-liner. >>> >> >> >> Ping. If there is a specific reason why this was not pushed, I would >> like to know. > > Pong - no one has reviewed it. Did it work for you? If so, state that, > and your review will serve as enough for me to push it :) Running 'make' and then 'make check' worked for me. So, I guess there is no problem in pushing this patch. -- Nehal J Wani -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list