Re: [PATCH 05/10] Fix crash on OOM in qemuAddRBDHost

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/23/13 15:23, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
> 
> When parsing the RBD hosts, it increments the 'nhosts' counter
> before increasing the 'hosts' array allocation. If an OOM then
> occurs when increasing the array allocation, the cleanup block
> will attempt to access beyond the end of the array. Switch
> to using VIR_EXPAND_N instead of VIR_REALLOC_N to protect against
> this mistake
> 
> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> ---
>  src/qemu/qemu_command.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

ACK.

Peter


Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]