Re: [PATCH] virsh-domain: Remove unnecessary check and tune code in cmdDesc()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I understand. Thanks for your reminding.


2013/9/17 Ján Tomko <jtomko@xxxxxxxxxx>
On 09/17/2013 11:16 AM, Hongwei Bi wrote:
> Since there is a check on buf through virBufferError(),
> it is not necessary to check desc again.

The buffer is used for the description provided on the virsh command line:
$ virsh desc <domain> Description

If you don't provide the description:

$ virsh desc --edit <domain>

then 'desc' is NULL and we need to fetch the existing domain description and
let the user edit it. Your patch removes this functionality.

Jan


--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]