Re: [PATCH] build: hoist system-specific checks before library checks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/17/2013 10:29 AM, Eric Blake wrote:
> Commit f92c7e3 fixed a regression for native builds, but introduced
> a regression for cross-compilation builds; in particular,
> ./autobuild.sh on a Fedora system with mingw cross-compiler fails
> with:
> 
> checking for qemu-kvm... /usr/bin/qemu-kvm
> checking for yajl_parse_complete in -lyajl... no
> checking for yajl_tree_parse in -lyajl... no
> configure: error: You must install the libyajl library & headers to compile libvirt
> 
> Since we default $with_qemu to 'yes' rather than 'check', and then
> flip that default based on platform-specific checks, those platform
> specifics need to come prior to any library checks that depend on
> the value of $with_qemu.
> 
> * configure.ac: Ensure system defaults are sane before checking
> for things that make decisions based on system default.
> 
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---
> 
> I'm tempted to push this under the build-breaker rule, so that
> I can get a successful ./autobuild.sh run.

That required one more patch:
https://www.redhat.com/archives/libvir-list/2013-September/msg01019.html

But now that my run completed successfully, I've gone ahead and pushed this.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]