Re: [PATCHv2] build: make autobuild require rpm build deps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/16/2013 09:56 AM, Daniel P. Berrange wrote:
> On Mon, Sep 16, 2013 at 09:40:32AM -0600, Eric Blake wrote:
>> I spent far too long on a new machine trying to figure out why
>> ./autobuild.sh failed due to an rpm build failure (complaining
>> that libvirt_parthelper was supposed to be packaged but was not
>> built), and finally traced it to a missing parted-devel
>> installation.  I learned that --nodeps is in place for
>> autobuilder setups, but for developers, removing it would make
>> rpmbuild error out much sooner for a less cryptic failure.
>>
>> * autobuild.sh: Conditionally drop --nodeps from rpmbuild lines.
>>
>> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
>> ---
>>
>> v2: make --nodeps conditional based on $AUTOBUILD_COUNTER; suggested
>> by Dan Berrange.
>>

> 
> ACK

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]