On 09/16/2013 08:31 AM, Daniel P. Berrange wrote: > On Fri, Sep 13, 2013 at 10:33:04AM -0600, Eric Blake wrote: >> Bother those kernel developers. In the latest rawhide, kernel >> and glibc have now been unified so that <netinet/in.h> and >> <linux/in6.h> no longer clash; but <linux/if_bridge.h> is still >> not self-contained. Because of the latest header change, the >> build is failing with: >> >> + if test "x$lv_cv_kernel_glibc_compatible" != xyes; then >> + AC_DEFINE([KERNEL_HEADERS_WORKAROUND], [1], >> + [define to 1 if Linux kernel headers require a workaround to avoid >> + compilation errors when mixed with glibc headers]) >> + fi > > nitpick - how about calling this LINUX_NETINET_IN_WORKAROUND or > something similarly specific about the header file that is actually > broken. Yeah, that does sound nicer, and less likely to cause confusion down the road. Consider it squashed in. > > ACK and pushing shortly. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list