On Mon, Sep 9, 2013 at 8:48 PM, Doug Goldstein <cardoe@xxxxxxxxxx> wrote: > A user came into #virt the other day and was trying to get libvirtd > to work with VMware Fusion 5, which is basically the Mac OS X version of > VMware Workstation. In helping him out I noticed a few limitations of our > VMX parser so I've added support through this patchset. I don't personally > have access or own VMware's product. > > v4: > * Half the patchset has been merged at this point > * Add back 'auto detect' support via <source startupPolicy='optional'/> > * Made device='lun' match device='cdrom' > * Patch 1 & 2 are new to the series > > v3: > * Dropped 'auto detect' support from series as it needs more work based on > feedback > * Added patch to combine virVMXFormatHardDisk and virVMXFormatCDROM into > one function. > * Converted to <disk type='block' device='lun'> instead of adding a > <driver> element to better match the behavior available via QEMU. > > v2: > * Added additional test cases and fixed issues that arose from those > > *** BLURB HERE *** > > Doug Goldstein (4): > Allow LUN type disks to have no source > Allow <source> for type=block to have no dev > VMX: Add support for 'auto detect' fileNames > VMX: Add a VMWare Fusion 5 configuration for tests > > docs/schemas/domaincommon.rng | 8 +- > src/conf/domain_conf.c | 9 ++- > src/vmx/vmx.c | 28 +++++-- > .../vmx2xml-cdrom-ide-raw-auto-detect.vmx | 5 ++ > .../vmx2xml-cdrom-ide-raw-auto-detect.xml | 24 ++++++ > .../vmx2xml-cdrom-scsi-raw-auto-detect.vmx | 6 ++ > .../vmx2xml-cdrom-scsi-raw-auto-detect.xml | 24 ++++++ > tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.vmx | 88 ++++++++++++++++++++++ > tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.xml | 39 ++++++++++ > tests/vmx2xmltest.c | 4 + > .../xml2vmx-cdrom-ide-raw-auto-detect.vmx | 14 ++++ > .../xml2vmx-cdrom-ide-raw-auto-detect.xml | 14 ++++ > .../xml2vmx-cdrom-scsi-raw-auto-detect.vmx | 15 ++++ > .../xml2vmx-cdrom-scsi-raw-auto-detect.xml | 14 ++++ > tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.vmx | 30 ++++++++ > tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.xml | 41 ++++++++++ > tests/xml2vmxtest.c | 4 + > 17 files changed, 356 insertions(+), 11 deletions(-) > create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-ide-raw-auto-detect.vmx > create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-ide-raw-auto-detect.xml > create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-scsi-raw-auto-detect.vmx > create mode 100644 tests/vmx2xmldata/vmx2xml-cdrom-scsi-raw-auto-detect.xml > create mode 100644 tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.vmx > create mode 100644 tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.xml > create mode 100644 tests/xml2vmxdata/xml2vmx-cdrom-ide-raw-auto-detect.vmx > create mode 100644 tests/xml2vmxdata/xml2vmx-cdrom-ide-raw-auto-detect.xml > create mode 100644 tests/xml2vmxdata/xml2vmx-cdrom-scsi-raw-auto-detect.vmx > create mode 100644 tests/xml2vmxdata/xml2vmx-cdrom-scsi-raw-auto-detect.xml > create mode 100644 tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.vmx > create mode 100644 tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.xml > > -- > 1.8.1.5 > Ping for anyone with free time to review. -- Doug Goldstein -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list