Re: [PATCHv6 1/5] domifaddr: Implement the public APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Eric, could you please share your views on the discussion?


On Sun, Sep 8, 2013 at 2:42 PM, Osier Yang <jyang@xxxxxxxxxx> wrote:
[......]



+ *
+ * If 0 is passed as @flags, libvirt will choose the best way, and won't
+ * include agent in it.

I'm thinking if we don't need to be so complicated, by defaulting to one
of _LEASE or _SNOOP explicitly.

That says (conclusion of all of above), I'm wondering if define the enum like
blow is better.


typedef enum {
    VIR_DOMAIN_INTERFACE_ADDRESSES_AGENT = (1 << 1), /* Query qemu guest agent */


And s/AGENT/GUEST_AGENT/, since "AGENT" could mean too much than "guest agent"





--
Nehal J Wani
UG3, BTech CS+MS(CL)
IIIT-Hyderabad
http://commandlinewani.blogspot.com
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]